Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change transition selection component not working #83

Open
whizkidTRW opened this issue Sep 21, 2020 · 7 comments
Open

Change transition selection component not working #83

whizkidTRW opened this issue Sep 21, 2020 · 7 comments

Comments

@whizkidTRW
Copy link

We have an ATEM Mini Pro (v8.4) and I'm trying to turn the upstream keyer on and off directly before a transition in order to control the state of our custom PIP when using upstream keyer 1 DVE configured to an input. The 'change transition selection component' is exactly what I wanted and have downloaded the latest Companion (2.1.1 - 4797bf3-2584 at the time of this writing) but when I configure it to either 'Key 1 & On Air' or 'Key 1 & Off Air', it does nothing. Even with a dedicated button to turn it on and off, set to Toggle, Off, or On, it does nothing. Is this supposed to work on the Mini Pro or is this a known issue? Otherwise, this appears to be a bug. I'd so like to use this instead of the macros I'm using today, since those only toggle it on or off and don't set it direct to a specific state.

@Julusian
Copy link
Member

I have just tested this in the exact same build and it is working for my mini pro iso, so I don't know why it wouldnt be working for you.

Just to check, you are expecting the yellow row of buttons here to be changing. And you have background already enabled? (the atem wont let that it go to nothing)
image

@whizkidTRW
Copy link
Author

whizkidTRW commented Sep 21, 2020 via email

@whizkidTRW
Copy link
Author

whizkidTRW commented Sep 23, 2020 via email

@Julusian
Copy link
Member

I dont follow what you mean with:

it would be nice if the "Change transition selection component" feature, when setting the Key 1 state to a specific On or Off state didn't do the opposite if that button is hit a second time

@cybershoe
Copy link

Tacking on here, because I feel like I'm running into the same issue and I'm not clear from the thread what the resolution was.

Is there documentation anywhere about what the "Change transition selection component" action is supposed to do? Based on the naming, I would expect that, for example, if Key1 is currently deselected for the next transition, and if I execute the "Change transition selection component" action with following options:

M/E: M/E 1
Component: Key 1
State: On

that it would set Key 1 as "On" for the next transition, but much like OP's initial description, the state of the next transition doesn't change at all for me. I'm also unsure what OP is referring to with the "interaction between the "Change transition selection" and the "Change transition selection component" feature."

Companion 2.1.2 build f4bcaf3-2679
ATEM Mini Pro firmware 8.6 build 2562fc70

@Julusian
Copy link
Member

Julusian commented Jun 7, 2021

that it would set Key 1 as "On" for the next transition,

@cybershoe yes, that is how it is supposed to work and is whenever I test it

The difference between the two is this:

  • "Change transition selection component" - changes one of the background/key1/key2
  • "Change transition selection" - changes the whole selection to whatever is specified

@cybershoe
Copy link

I noticed that I mistyped my scenario... the state isn't "On", the state is "On Air". That implies that the selection will result in the key becoming "On Air" as part of the next transition (i.e. if key 1 is on air, then key 1 next transition is disabled, else key 1 transition is enabled).

Either this is a terminology problem (in which case I'd suggest "On Air" be changed to just "On", since it doesn't seem to affect "On Air" status, just whether the selection is "On"), or even better, change it to be "Selected" and "Not selected".

We're getting into feature request territory here, but ideally I'd like to see 5 options:

  • Selected: The component is selected for the next transition, no matter what
  • Not selected: The component is not selected for the next transition, unless it's the only currently selected component, in which case no action is taken
  • Toggle: What it currently does, toggle the selection state for the component
  • On Air: (only available for key components) If the component is currently on air, the component is not selected for the next transition (component remains on air), otherwise it is selected (component goes on air)
  • Off Air: (only available for key components) If the component is currently not on air, the component is not selected for the next transition (component remains off air), otherwise it is not selected (component goes off air).

Admittedly I see this getting pretty hairy, and I expect that it's just a mislabelling of what's supposed to be the "On" option. Getting #1052 in companion core implemented would get away from that though and let us define this behaviour through conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants