Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin does not reconnect #4

Closed
schw4rzlicht opened this issue May 1, 2024 · 6 comments
Closed

Plugin does not reconnect #4

schw4rzlicht opened this issue May 1, 2024 · 6 comments

Comments

@schw4rzlicht
Copy link

Hey there!

When e.g. rebooting a remote device, the SSH connection is not re-established. Would be good if that'd be the case. Our use-case is to reboot headless media servers in a show environment from another headless server that has Companion running.

Thanks!

@Jibun-no-Kage
Copy link

Jibun-no-Kage commented Aug 7, 2024

Looking for answer to this as well, comparable use case, anyone one actively supporting this module? Just asking, since this issue was posted some time ago.

@cyberblaststudios
Copy link
Collaborator

I will try my best to get to this within the next several days. Thank you for your patience!

@Jibun-no-Kage
Copy link

Thank you very much for addressing this request. Always appreciate when modules are supported!

@cyberblaststudios
Copy link
Collaborator

In release v1.3.0 (https://github.com/bitfocus/companion-module-generic-ssh/releases/tag/v1.3.0) I have added a re-connect feature that will attempt to reconnect SSH every second if it loses connection by receiving a TCP reset from the server, or fails to connect to the server. This build should be included in the betas in the near future, and eventually the stable version.

I will close this issue now that I have created the release with the fix. If you still have trouble, feel free to comment here.

@Jibun-no-Kage
Copy link

Yeah, will let you know. Thanks again, I know time is limited, but just the same, appreciate you supporting the module. Just had a thought... maybe in the future... make this reconnect a configurable option? Meaning it can be toggled on or off? Just was thinking about possible use cases. Or it already is per your update?

@cyberblaststudios
Copy link
Collaborator

Yeah, will let you know. Thanks again, I know time is limited, but just the same, appreciate you supporting the module. Just had a thought... maybe in the future... make this reconnect a configurable option? Meaning it can be toggled on or off? Just was thinking about possible use cases. Or it already is per your update?

Right now, it's not a configurable option to reconnect. I'm curious what a use case would be for that. I am all ears on suggestions.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants