fix: Pagenumber button not updated correctly #2468

bitfocus · Jun 4, 2023 · db19510 · db19510
1 parent 9cc0ebe
commit db19510
Showing 1 changed file with 14 additions and 1 deletion.
diff --git a/webui/src/ButtonRenderCache.jsx b/webui/src/ButtonRenderCache.jsx
@@ -27,9 +27,14 @@ export class ButtonRenderCache extends EventEmitter {
 	}
 
 	bankChange(page, bank, render) {
+		page = Number(page)
+		bank = Number(bank)
+		if (isNaN(page) || isNaN(bank)) return
+
+		const newImage = dataToButtonImage(render)
+
 		const subsForPage = this.#pageSubs[page]
 		if (subsForPage && subsForPage.size) {
-			const newImage = dataToButtonImage(render)
 			const newImages = {
 				...this.#pageRenders[page],
 				[bank]: newImage,
@@ -38,6 +43,14 @@ export class ButtonRenderCache extends EventEmitter {
 
 			// TODO - debounce?
 			this.emit('page', page, newImages)
+		}
+
+		const id = CreateBankControlId(page, bank)
+		const subsForBank = this.#bankSubs[id]
+		if (subsForBank && subsForBank.size > 0) {
+			this.#bankRenders[id] = newImage
+
+			// TODO - debounce?
 			this.emit('bank', page, bank, newImage)
 		}
 	}