Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bonjour discovery helper #2087

Closed
2 tasks done
Julusian opened this issue Aug 7, 2022 · 2 comments · Fixed by #2428
Closed
2 tasks done

Bonjour discovery helper #2087

Julusian opened this issue Aug 7, 2022 · 2 comments · Fixed by #2428
Labels
area/module-api Module related Enhancement New feature or request
Milestone

Comments

@Julusian
Copy link
Member

Julusian commented Aug 7, 2022

Is this a feature relevant to companion itself, and not a module?

  • I believe this to be a feature for companion, not a module

Is there an existing issue for this?

  • I have searched the existing issues

Describe the feature

Many devices (blackmagic, chromecast, dante) use bonjour(mdns) to announce themselves to the network to allow for auto discovery.

The bmd-atem module has had mdns support in it for a while to be able to suggest ip addresses that can be added.
In 2.3 and earlier, this has been fine as it has created a single mdns browser shared across all instances. But in 3.0, due to the threading changes this will end up with one browser per instance.

Having many bonjour browsers distributed like this will not be very efficient. It would be better if there was a central bonjour helper run by companion, that instances could use for doing discovery. This would also less us be more intelligent with it, such as having a bonjour-device field type for the configuration, to allow for live updating suggestions while the config panel is open.

Usecases

Various modules could make use of this:

  • bmd-atem (and every other bmd probably)

Probably others, if there is a good example of how to check and get it setup.

This could also be used as the basis of discovering other companion installations visible on the network.

@Julusian Julusian added the area/module-api Module related label Aug 7, 2022
@krocheck
Copy link
Member

krocheck commented Aug 7, 2022

Shure products have mdns.

@Julusian Julusian added the Enhancement New feature or request label Aug 9, 2022
@Julusian Julusian linked a pull request Apr 23, 2023 that will close this issue
@Julusian Julusian added this to the v3.1 milestone May 17, 2023
@Julusian
Copy link
Member Author

This is possible in 3.2 (current beta builds)

https://github.com/bitfocus/companion-module-base/wiki/Bonjour-device-discovery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/module-api Module related Enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants