Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Action Recorder #1001 #2125

Merged
merged 19 commits into from
Sep 28, 2022
Merged

feat: Action Recorder #1001 #2125

merged 19 commits into from
Sep 28, 2022

Conversation

Julusian
Copy link
Member

@Julusian Julusian commented Sep 18, 2022

Depends on bitfocus/companion-module-base#11

This is an implementation of #1001, without any internal actions for now.

The idea is that you can go to the 'Action Recorder' tab, select the modules you want to record actions from (only ones which support this will be offered), and then start recording.
The module is then free to emit actions, which shall be recorded and shown in a list.
Screenshot from 2022-09-18 21-30-35

Once you are happy, you can click finish and select the button/trigger to put the actions on, as well as which 'action set' (down/up) the actions should be in.
Additionally, you can pause and resume the recording at any point with the toggle switch. And while recording is paused, you can make manual edits to the actions in the list.
image

For modules to support this, they need to implement the handleStartStopRecordActions method and then they are free to this.recordAction(...) whenever they have something that should be recorded.

Example module: bitfocus/companion-module-bmd-atem@8ac9373#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80

TODO:

  • Fix bank selector image loading
  • example in a module

@Julusian Julusian linked an issue Sep 18, 2022 that may be closed by this pull request
@Julusian Julusian marked this pull request as ready for review September 27, 2022 19:17
@Julusian Julusian merged commit a228a92 into develop Sep 28, 2022
@Julusian Julusian deleted the feat/record-actions branch September 28, 2022 11:02
@krocheck krocheck restored the feat/record-actions branch October 4, 2022 22:45
@krocheck krocheck deleted the feat/record-actions branch October 4, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Macro/Learn function
1 participant