Skip to content
This repository has been archived by the owner on Dec 12, 2023. It is now read-only.

Add support for descriptor includes #7

Closed
wtschreiter opened this issue Feb 3, 2019 · 0 comments
Closed

Add support for descriptor includes #7

wtschreiter opened this issue Feb 3, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request
Projects

Comments

@wtschreiter
Copy link
Contributor

TL;DR

Add support to reuse descriptors by including them into other descriptors.

UseCase

We do have scenarios there we to deploy the same application stack on different rancher managed clusters.
Depending on the abilities of the cluster we have to handle stuff as persistent volumes and storage classes very different. But the set of applications is at the same time very similar.
Currently we have the choice of duplicating the full descriptor or implementing some template logic for the different clusters. Both not very maintainable.

Solution Proposal

  • Have includes declared in the metadata section of the descriptor.
  • Have the resulting descriptor object constructed from all includes and the including descriptor
    • The later the include the higher the precedence for duplicate names.
    • The including descriptor has the highest precedence.
  • Create a error response on a detected include cycle.
api_version: v1.0
kind: Project
metadata:
  name: sample-project
  includes:
    - relative-include.yaml
    - /tmp/ablsolute-include.yaml
@wtschreiter wtschreiter added the enhancement New feature or request label Feb 3, 2019
@wtschreiter wtschreiter added this to the Backlog milestone Feb 3, 2019
@wtschreiter wtschreiter added this to To do in 1.1.0 Feb 15, 2019
@wtschreiter wtschreiter removed this from the Backlog milestone Feb 15, 2019
@wtschreiter wtschreiter moved this from To do to In progress in 1.1.0 Mar 8, 2019
@wtschreiter wtschreiter self-assigned this Mar 16, 2019
1.1.0 automation moved this from In progress to Done Mar 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
1.1.0
  
Done
Development

No branches or pull requests

1 participant