Add eslint and fix lint errors #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golopot
commented
Jun 12, 2019
| @@ -249,7 +249,7 @@ exports.logger = function logger(options) { | |||
| return function (req, res, next) { | |||
| var coloredRes = {}; | |||
|
|
|||
| var currentUrl = req.originalUrl || req.url; | |||
| var currentUrl = req.originalUrl || req.url; | |||
There was a problem hiding this comment.
Irregular whitespace.
golopot
commented
Jun 12, 2019
| var testHelperOptionsWithoutBlacklist = { loggerOptions: {} }; | ||
| return errorLoggerTestHelper(testHelperOptionsWithoutBlacklist).then(function (result) { | ||
| result.log.meta.should.have.property('trace'); | ||
| }); |
There was a problem hiding this comment.
Unreachable code path. It does not look like a valid test.
golopot
commented
Jun 12, 2019
| @@ -1,9 +1,6 @@ | |||
| var util = require('util'); | |||
golopot
commented
Jun 12, 2019
| @@ -676,7 +668,7 @@ describe('express-winston', function () { | |||
|
|
|||
| describe('when middleware function is invoked on a route that returns JSON', function() { | |||
| it('should parse JSON in response body', function() { | |||
| var bodyObject = { "message": "Hi! I\'m a chunk!" }; | |||
There was a problem hiding this comment.
Unnecessary escape.
|
@golopot I can merge as soon as the conflicts are resolved ✌️ Good stuff. |
|
Do you have a preference on resolving merge conflict? Do you prefer it be done with a rebase and force push, or a new merge commit? |
|
you can commit multiple times, I can squash when merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.