Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing exceptionToMeta and skip to TypeScript definition #234

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Add missing exceptionToMeta and skip to TypeScript definition #234

merged 1 commit into from
Feb 13, 2020

Conversation

foxted
Copy link
Contributor

@foxted foxted commented Feb 6, 2020

While using this package with Nest.js, I realized there was no ignoreRoutes option on the errorLogger. However, the exceptionToMeta and skip options are available, but were missing from the TypeScript definition.

  • Add missing exceptionToMeta and skip from errorLogger options to TypeScript definition
  • Update express-winston-test.ts file with new options

@bithavoc
Copy link
Owner

bithavoc commented Feb 6, 2020

Hey @foxted thanks for the PR.

I don't understand the decision to remove responseField, it's still in use.

@foxted
Copy link
Contributor Author

foxted commented Feb 6, 2020

I couldn't find it in the errorLogger method and the docs, so I assume it wasn't used anymore. I can totally add that back :)

@bithavoc
Copy link
Owner

Please add it back and I'll publish the new version ASAP ✌️

@foxted
Copy link
Contributor Author

foxted commented Feb 12, 2020

Done :)

@bithavoc bithavoc merged commit 11fc143 into bithavoc:master Feb 13, 2020
@bithavoc
Copy link
Owner

Published https://github.com/bithavoc/express-winston/releases/tag/v4.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants