Add test coverage with Blanket.js to close #54 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You done with this? |
|
What, you think I might add a fourth unrelated change? Haha. I'll remove the stuff from the README as per your comment on #59 and then re-push, but other than that, I think it's done. Are you ok with requiring 100% coverage, or should that threshold be lower? |
- HTML Coverage report - `npm run-script test-coverage` - Travis-CI test which fails if coverage < 100% - `npm run-script test-travis` Also tweaked tests to provide 100% coverage, updated `.travis.yml` to only run `test-travis` script if Node version > 0.6, updated Readme.md to make note of test changes. And yet more, move underscore template settings into `_.template()` instead of overriding underscore settings, which should resolve bithavoc#17
floatingLomas
force-pushed
the
coverage
branch
from
3acb877
to
18aac7e
Compare
bithavoc
pushed a commit
that referenced
this pull request
Jan 30, 2015
Add test coverage with Blanket.js to close #54
|
It's fine, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run-script test-coveragenpm run-script test-travisAlso tweaked tests to provide 100% coverage, updated
.travis.ymlto only runtest-travisscript if Node version > 0.6, updated Readme.md to make note oftest changes.
And yet more, move underscore template settings into
_.template()instead of overriding underscore settings, which should resolve #17