allow to ignore routes based on req and res #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -144,6 +144,7 @@ function logger(options) { | |||
| options.msg = options.msg || "HTTP {{req.method}} {{req.url}}"; | |||
| options.colorStatus = options.colorStatus || false; | |||
| options.expressFormat = options.expressFormat || false; | |||
| options.ignoreRoute = options.ignoreRoute || function () { return false; }; | |||
There was a problem hiding this comment.
Shouldn't we be making sure options.ignoreRoute is actually a function?
There was a problem hiding this comment.
Yes. I will add that.
There was a problem hiding this comment.
Done... And I squashed the commit for the same price.
Added an optional ignoreRoute option that expects a function that receives req and res as params and should return true when the request should be logged, false otherwise. Fixes bithavoc#63 check if ignoreRoute is a function
saadtazi
force-pushed
the
feature/ignoreRoute
branch
from
00e2185
to
70a59cb
Compare
|
👍 for this |
floatingLomas
added a commit
that referenced
this pull request
Apr 9, 2015
allow to ignore routes based on req and res
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional ignoreRoute option that expects a function that receives req and res as params and should return true when the request should be ignored (= not logged), false otherwise.
IgnoredRoutes now also uses req.originalUrl or url instead of req.path, which should fix #63