Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip option added #69

Merged
merged 1 commit into from Apr 10, 2015
Merged

Skip option added #69

merged 1 commit into from Apr 10, 2015

Conversation

ppitonak
Copy link
Contributor

@ppitonak ppitonak commented Apr 8, 2015

Skip option added with same behavior as in https://github.com/expressjs/morgan. Function to determine if logging is skipped, defaults to false. This function
will be called as skip(req, res).

app.use(expressWinston.logger({
  transports: ...
  skip: function(req, res) { return res.statusCode < 400 }
}));

@floatingLomas
Copy link
Collaborator

LGTM, but @bithavoc or whoever else will have to merge it.

@bithavoc
Copy link
Owner

bithavoc commented Apr 8, 2015

@floatingLomas you have been commiter since forever

@floatingLomas
Copy link
Collaborator

I was at one point. I don't currently have write access, or at least that's what the message is telling me...

@floatingLomas
Copy link
Collaborator

Ok, I looked it up. :P I had write permissions when this repo was under the firebaseco namespace because I was a part of that group; I'm pretty sure I lost those permissions whenever you moved it into your own namespace.

@bithavoc
Copy link
Owner

bithavoc commented Apr 9, 2015

@floatingLomas fixed, pls ping me when you need npm push, actually I can give you publishing rights, what's your NPM user?

@floatingLomas
Copy link
Collaborator

@bithavoc, cool. Perhaps not surprisingly, it is floatinglomas. :)

I'll do some PR cleanup in the morning.

@floatingLomas
Copy link
Collaborator

@ppitonak, can you rebase the new stuff in bithavoc/express-winston's master onto this and re-push it, so I can merge it?

@ppitonak
Copy link
Contributor Author

rebased

floatingLomas added a commit that referenced this pull request Apr 10, 2015
@floatingLomas floatingLomas merged commit 1aa3861 into bithavoc:master Apr 10, 2015
@ppitonak ppitonak deleted the option_skip branch April 13, 2015 12:06
@ppitonak
Copy link
Contributor Author

Thanks for merging, when do you plan to publish release?

@floatingLomas
Copy link
Collaborator

Soon as @bithavoc adds me for npm publishing. :)

@bithavoc
Copy link
Owner

In a few mins

@bithavoc
Copy link
Owner

@floatingLomas done, you're the man now.

@floatingLomas
Copy link
Collaborator

Awesomo. Published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants