New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip option added #69
Conversation
LGTM, but @bithavoc or whoever else will have to merge it. |
@floatingLomas you have been commiter since forever |
I was at one point. I don't currently have write access, or at least that's what the message is telling me... |
Ok, I looked it up. :P I had write permissions when this repo was under the firebaseco namespace because I was a part of that group; I'm pretty sure I lost those permissions whenever you moved it into your own namespace. |
@floatingLomas fixed, pls ping me when you need |
@bithavoc, cool. Perhaps not surprisingly, it is floatinglomas. :) I'll do some PR cleanup in the morning. |
@ppitonak, can you rebase the new stuff in |
rebased |
Thanks for merging, when do you plan to publish release? |
Soon as @bithavoc adds me for |
In a few mins |
@floatingLomas done, you're the man now. |
Awesomo. Published. |
Skip
option added with same behavior as in https://github.com/expressjs/morgan. Function to determine if logging is skipped, defaults tofalse
. This functionwill be called as
skip(req, res)
.