expressFormat use originalUrl if available #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using nested routers in e.g. express, the router modifies req.url to only contain the router relevant url part. For that matter, when logging req.url, you wouldn't see the complete original url. Express adds req.originalUrl which contains the url that was called by the client. If this property is available, it should be used over req.url in the log format
floatingLomas
added a commit
that referenced
this pull request
Apr 9, 2015
expressFormat use originalUrl if available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using nested routers in e.g. express, the router modifies req.url to only contain the router relevant url part. For that matter, when logging req.url, you wouldn't see the complete original url. Express adds req.originalUrl which contains the url that was called by the client. If this property is available, it should be used over req.url in the log format