-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Winston to 1.0.0 #81
Conversation
No other way to do it |
Is that a question or a statement? |
No, this is what major versions are for, we follow semver.org and everybody who is smart enough to use this library should have added minor or patch revisions wildcards in package.json What we should do is branch and keep maintaining both 0.3 and 1.0 branches. How does that sounds? |
Sounds great. |
Allright, let's add instructions to the readme explaining 1.0 and 0.3 requirements and merge this 1.0 branch into master |
680879a
to
8b56cd4
Compare
should be: newcomers should use our latest 1.0 as this: |
Sooooooo... Newcomers should start with the latest branch which makes use of winston 1.x.x:
If you're already using express-winston, and want to stick with the stable version based on winston 0.9.x, you should instead do:
...? |
yep, like this:
|
8b56cd4
to
a149948
Compare
Anything blocking this merge? :) If so, I'd be happy to help! Thanks. |
I can't honestly remember. I'll try to find a moment in the next little while to double-check and get back to you. |
Thanks, no hurry! I just integrated it and since I'm using my own |
I remember what the block was:
I'll try to get this done in the next couple of days. |
@floatingLomas, any chance you could get this done this week? Otherwise let me know, I'm needing this now. |
Upgrade Winston to 1.0.0
Done. Sorry for the delay, folks. @bithavoc, can you change the default Github branch to |
@bithavoc, I finally got around to trying this out (re #74), and everything passes - so either we're cool, or we're missing some tests.
I don't really have time to poke and prod, so maybe we should just call this 0.4.0 and wait for people to start yelling if there's a problem...?