Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Winston to 1.0.0 #81

Merged
merged 1 commit into from
Aug 26, 2015

Conversation

floatingLomas
Copy link
Collaborator

@bithavoc, I finally got around to trying this out (re #74), and everything passes - so either we're cool, or we're missing some tests.

I don't really have time to poke and prod, so maybe we should just call this 0.4.0 and wait for people to start yelling if there's a problem...?

@bithavoc
Copy link
Owner

No other way to do it

@floatingLomas
Copy link
Collaborator Author

Is that a question or a statement?

@bithavoc
Copy link
Owner

No, this is what major versions are for, we follow semver.org and everybody who is smart enough to use this library should have added minor or patch revisions wildcards in package.json

What we should do is branch and keep maintaining both 0.3 and 1.0 branches.

How does that sounds?

@floatingLomas
Copy link
Collaborator Author

Sounds great.

@bithavoc
Copy link
Owner

Allright, let's add instructions to the readme explaining 1.0 and 0.3 requirements and merge this 1.0 branch into master

@floatingLomas
Copy link
Collaborator Author

This make sense?

@bithavoc
Copy link
Owner

should be: 0.3.x which is our current stable.

newcomers should use our latest 1.0 as this: 1.x

@floatingLomas
Copy link
Collaborator Author

Sooooooo...


Newcomers should start with the latest branch which makes use of winston 1.x.x:

npm install express-winston

If you're already using express-winston, and want to stick with the stable version based on winston 0.9.x, you should instead do:

npm install express-winston@0.3.x

...?

@bithavoc
Copy link
Owner

yep, like this:

npm install express-winston@0.3.x --save

@mathieumg
Copy link

Anything blocking this merge? :) If so, I'd be happy to help! Thanks.

@floatingLomas
Copy link
Collaborator Author

I can't honestly remember. I'll try to find a moment in the next little while to double-check and get back to you.

@mathieumg
Copy link

Thanks, no hurry! I just integrated it and since I'm using my own winstonInstance this isn't a showstopper as I thought it would be. Works great, good job! 👍

@floatingLomas
Copy link
Collaborator Author

I remember what the block was:

  • need to create 0.x and 1.x branches so we can keep going on both
  • small children take up a lot of time

I'll try to get this done in the next couple of days.

@bithavoc
Copy link
Owner

@floatingLomas, any chance you could get this done this week? Otherwise let me know, I'm needing this now.

floatingLomas added a commit that referenced this pull request Aug 26, 2015
@floatingLomas floatingLomas merged commit 16c2e17 into bithavoc:master Aug 26, 2015
@floatingLomas floatingLomas deleted the upgrade-winston branch August 26, 2015 17:43
@floatingLomas
Copy link
Collaborator Author

Done. Sorry for the delay, folks.

@bithavoc, can you change the default Github branch to 1.x instead of master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants