Not obvious that to 'view' one should click 'edit' #47
Comments
ghost
assigned 
|
Brian, I think we should discuss this some more. I don't think it is intuitive to 'View' in order to 'Edit'. I am actually not a fan of 'View' to begin with. I only find it necessary to have a View if you don't want some people to have Edit permission, or if some people continue to accidentally edit a record(which I don't understand how this happens). In our case we do have 'View' for Plans, but I think that is poorly named(and I want to rename it). It should be something like 'Execute Plan'? |
|
Okay, Heather would like to be able to click links to view a test case when looking at a suite of test cases so she does not have to go back and hunt for each test case. |
|
I've added back View links to test cases and suites. You have to now view a test case or suite before you can edit it. When viewing a suite, each test case has a view link as well. |
* app/controllers/plans_controller.rb (open): supports /plans/1/open now in addition to /plans/open * app/controllers/suites_controller.rb (show): new method (edit): include test_cases so view doesn't execute the sql * app/controllers/test_cases_controller.rb (show): avoids calling 'first' on the relation until after other filters are applied * app/views/partials/_item_menu.html.erb: removed Edit, added View, removes some custom Plan logic, add Open for closed plans * app/views/partials/_view_buttons.html.erb: new file * app/views/steps/create.js.erb: pass locals :disabled => false to render partial 'test_cases/step' * app/views/steps/destroy.js.erb: ditto * app/views/steps/update.js.erb: ditto * app/views/suites/_current_cases_item_menu.html.erb -> app/views/suites/_current_cases_edit_item_menu.html.erb * app/views/suites/_current_cases_view_item_menu.html.erb: new file * app/views/suites/_form.html.erb: supports a disabled mode for show action * app/views/suites/edit.html.erb: pass disabled => false to render partial 'form' * app/views/suites/new.html.erb: ditto * app/views/suites/show.html.erb: new file * app/views/suites/sort.js.erb: pass locals :disabled => false to render partial 'test_cases/test_case' * app/views/test_cases/_form.html.erb: supports a disabled mode for show action * app/views/test_cases/_step.html.erb: when disabled is true, omits the Edit/Destroy links * app/views/test_cases/_step_list.html.erb: when disabled is true, the Add Step button is disabled * app/views/test_cases/_view_tag_handler.erb: new file * app/views/test_cases/edit.html.erb: pass :disabled => false as locals to render partial 'form' * app/views/test_cases/new.html.erb: ditto * app/views/test_cases/show.html.erb: new file * app/views/test_cases/sort.js.erb: pass :disabled => false as local to render test_cases/step * config/locales/en.yml: add unassociate, viewing, close, open * config/routes.rb: add member post 'open' to plans, no longer except :show on suites, has all resources routes * spec/controllers/plans_controller_spec.rb: add tests for close, open * spec/controllers/suites_controller_spec.rb: add tests for show * spec/requests/suites_spec.rb: check for View instead of Edit, add tests for when viewing a suite (show action) * spec/requests/test_cases_spec.rb: check for View instead of Edit, add tests for when viewing a test case (show action) * spec/routing/plans_routing_spec.rb: add routing tests for close, open * spec/routing/suites_routing_spec.rb: add routing tests for show
|
Tests are done, I'm closing this issue. |
For test cases and suites, there is no link to 'view'. For a new user it is potentially unintuitive to click 'edit' in these cases. Some options listed below:
The text was updated successfully, but these errors were encountered: