Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtual scroll example 8 issue #253

Closed
NitinMagdum opened this issue Aug 12, 2020 · 3 comments · Fixed by #254 or #255
Closed

virtual scroll example 8 issue #253

NitinMagdum opened this issue Aug 12, 2020 · 3 comments · Fixed by #254 or #255
Labels
bug Something isn't working
Milestone

Comments

@NitinMagdum
Copy link

i am using this plugin for infinite scroll and search functionality but facing one issue

https://stackblitz.com/github/bithost-gmbh/ngx-mat-select-search-example?spm=a2c6h.14275010.0.0.4843743e0qwXH3&file=src%2Fapp%2Fapp.component.html

how to reproduce the issue
1 - click select box scroll for some time select a value remove focus from select by clicking outside the box
2 - then again click on select box dont do anything click outside the existing selected value is not getting attached to the box

verify the behavior with single selection example 1, here its working correctly after above step 2 the selected value in step 1 will be remain selected in the box

@NitinMagdum NitinMagdum added the bug Something isn't working label Aug 12, 2020
@macjohnny
Copy link
Member

you can prevent resetting the options to the initial list by

filter(([isOpen,]) => isOpen === true && !this.ctrl.value),

https://stackblitz.com/edit/github-d1yhjs?file=src/app/examples/08-infinite-scroll-example/infinite-scroll-example.component.ts

I will update the example

macjohnny added a commit that referenced this issue Aug 12, 2020
macjohnny added a commit to bithost-gmbh/ngx-mat-select-search-example that referenced this issue Aug 12, 2020
macjohnny added a commit that referenced this issue Aug 12, 2020
@macjohnny
Copy link
Member

@NitinMagdum Thanks for reporting this issue

@macjohnny macjohnny reopened this Aug 12, 2020
@macjohnny
Copy link
Member

unfortunately, #254 broke the search functionality, so I will fix the example

macjohnny added a commit that referenced this issue Aug 12, 2020
macjohnny added a commit that referenced this issue Aug 12, 2020
macjohnny added a commit that referenced this issue Sep 8, 2020
…not available in the initial batch (#255)

* fix: infinity scrolling not working correctly when selecting a value not available in the initial batch

#253

* fixup! fix: infinity scrolling not working correctly when selecting a value not available in the initial batch

* fixup! fix: infinity scrolling not working correctly when selecting a value not available in the initial batch
@macjohnny macjohnny added this to the 3.1.0 milestone Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants