Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiple selection not restored correctly after search #260

Closed
macjohnny opened this issue Sep 3, 2020 · 0 comments · Fixed by #261
Closed

multiple selection not restored correctly after search #260

macjohnny opened this issue Sep 3, 2020 · 0 comments · Fixed by #261
Labels
bug Something isn't working
Milestone
3.1.0

Comments

@macjohnny
Copy link
Member

macjohnny commented Sep 3, 2020 •
edited
Loading

In the Stackblitz of this repo, precisely in mat-select multiple with toggle selection; here is the steps to reproduce it:

  1. Open multiselector with toggle,
  2. Click checkbox toggle all (select all)
  3. Click Checkbox toggle again (unselect all)
  4. Make some search in mat-select, and click one of them
  5. The previous selection is selected, this is a error because previous we unselect all by toggle selection.

PD: this issue is not present in 3.0.0

Originally posted by @begandroide in #249 (comment)

A gif of the issue:

ezgif com-video-to-gif (1)
@macjohnny macjohnny added the bug Something isn't working label Sep 3, 2020
@macjohnny macjohnny mentioned this issue Sep 3, 2020
Closed
macjohnny added a commit that referenced this issue Sep 8, 2020
@macjohnny
fix: properly restore multi-select options when filtering
8270ccf 
#260
@macjohnny macjohnny mentioned this issue Sep 8, 2020
Merged
macjohnny added a commit that referenced this issue Sep 8, 2020
@macjohnny
fix: properly restore multi-select options when filtering (#261)
d526aeb 
* fix: properly restore multi-select options when filtering

#260

* fixup! fix: properly restore multi-select options when filtering

* Update src/app/mat-select-search/mat-select-search.component.ts

* fixup! fix: properly restore multi-select options when filtering

* fixup! fixup! fix: properly restore multi-select options when filtering
@macjohnny macjohnny added this to the 3.1.0 milestone Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

fix: properly restore multi-select options when filtering bithost-gmbh/ngx-mat-select-search
1 participant
@macjohnny