Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

background issue for Angular Material >16.2 with toggle all button #435

Closed
macjohnny opened this issue Aug 31, 2023 · 5 comments · Fixed by #437
Closed

background issue for Angular Material >16.2 with toggle all button #435

macjohnny opened this issue Aug 31, 2023 · 5 comments · Fixed by #437

Comments

@macjohnny
Copy link
Member

          What worked for me for Angular Material >16.2 versions is this :
.mat-select-search-inner-multiple {
    &.mat-select-search-inner-toggle-all {
      background-color: var(--mat-select-panel-background-color);
    }
  }

In my opinion, this should be implemented in this part
https://github.com/bithost-gmbh/ngx-mat-select-search/pull/434/files#diff-114f34682e5ad0081489bdbcabc0eec64a2611e2d60f79aae41700708fb03b7fL34

The other fix could be also removed! Please test to ensure that this is actually solving the issue and also if makes sense to implement it in the library as well!

Originally posted by @ioanbin in #433 (comment)

@macjohnny
Copy link
Member Author

@ioanbin thanks for your suggestion, this actually fixes an issue that is present in version 7.0.3, would you want to send a PR for this?

@ioanbin
Copy link

ioanbin commented Aug 31, 2023

@macjohnny sure, I will do it!

@ioanbin
Copy link

ioanbin commented Sep 1, 2023

@macjohnny Unfortunately, I can't implement the fix, because the project is not migrated to Angular 16 yet! This fix is valid only for Angular and Angular Material >16 versions. The library should be migrated to Angular 16 first!

@macjohnny
Copy link
Member Author

@ioanbin what you can do is to implement the fix, build the library locally, and copy over the build to the node_modules folder of https://github.com/bithost-gmbh/ngx-mat-select-search-example (which was migrated to ng 16). we don't migrate https://github.com/bithost-gmbh/ngx-mat-select-search on purpose, to make sure we are still compatible with that version and upwards

@ioanbin
Copy link

ioanbin commented Sep 5, 2023

@macjohnny But this will not fix the issue with the actual library though, am I right? My solution is not valid for 15 though and will cause styling issues! I will try to find a better solution, otherwise, when updating the library to 16.2 we can implement the fix. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants