Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add empty dependencies object #11

Merged
merged 1 commit into from
Feb 4, 2016
Merged

Conversation

voronianski
Copy link
Contributor

due to bug in npm:

This bug breaks bundling modules via browserify-cdn. Please merge this and patch version ASAP. Thanks!

due to bug in npm:

- npm/npm#6581 (comment)
- facebook/react#5918 (comment)

This bug breaks bundling modules via [browserify-cdn](https://wzrd.in/). Please merge this and patch version ASAP. Thanks!
@voronianski
Copy link
Contributor Author

@bitinn ping

@voronianski
Copy link
Contributor Author

@bitinn ping ping

bitinn added a commit that referenced this pull request Feb 4, 2016
add empty dependencies object to avoid npm bug
@bitinn bitinn merged commit 6a00f61 into bitinn:master Feb 4, 2016
@bitinn
Copy link
Owner

bitinn commented Feb 4, 2016

thx for the report, this is messed up on the npm's part, dependencies shouldn't be required.

@voronianski
Copy link
Contributor Author

@bitinn exactly, very old npm bug :( thanks in advance!

@voronianski
Copy link
Contributor Author

@bitinn could you also patch version and publish to npm?

@voronianski
Copy link
Contributor Author

@bitinn just for your information - browserify-cdn is used in this tool http://esnextb.in/ (allows to write es6/es7 code and import npm modules in browser).

@bitinn
Copy link
Owner

bitinn commented Feb 4, 2016

@voronianski could you use master or your branch at the moment, I would like to wait for coveralls to recover before publishing a new version.

lemurheavy/coveralls-public#713

@voronianski
Copy link
Contributor Author

@bitinn actually I'm not using your module directly.

One of the users of http://esnextb.in had problems with using @cycle/dom module which uses vdom-parser as a dependency - voronianski/esnextbin#4 (comment)

@voronianski
Copy link
Contributor Author

@bitinn this lemurheavy/coveralls-public#713 is closed, maybe it's time to patch version and publish to npm?

@voronianski
Copy link
Contributor Author

@bitinn ping ping

@bitinn
Copy link
Owner

bitinn commented Mar 20, 2016

Sorry for the delay, this is now published as v1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants