-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use native CSS parsing #9
Conversation
It looks like the Zuul build is complaining about a lack of sauce labs credentials, but the tests seem to pass otherwise |
I believe I have avoided using native style object due to some reasons (likely virtual-dom related), but can't recall it yet. Still, thx for providing a test case :) |
@bitinn The unit test "'should parse bracket style attribute on node'" initially failed when I made the changes. However, changing I suspect this may have been part of your initial rationale since that test seemed oddly specific. |
This would be useful to have since it would solve the issue of not having any inline styles in IE8 (#7) |
@niksy yep I would like to work on this soon. though I am not sure we will ever get full support for IE8. |
@bitinn I have some commits on my fork which normalize feature set for IE8 and for the project I’m currently working on vdom-parser works really great. I can submit PRs when you get time to work on this. |
I figure out why I didn't use CSS parser after merging this: phantomjs actually output differently from chrome. especially on inline input like Since this is intended for browser anyway, I will workaround the phantomjs issue... |
https://travis-ci.org/bitinn/vdom-parser/builds/117241478 Things are a lot worse than I remembered, Safari doesn't agree with Chrome. So we either generate additional patches for Safari (including iOS) or for Chrome (including android) using CSS parser. Maybe I have to back out of this... |
landed in v1.3.0 |
Hello @bitinn
I recently created a library similar to vdom-parser at https://github.com/AkeemMcLennon/dom2hscript
I noticed your version had bug where it failed to parse certain CSS properties that contained semicolons such a base64 encoded strings. This pull request uses the browser's native css parser to improve accuracy.