Add React storybook #11
Merged
+2,152
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenju
commented
Jan 11, 2017
| @@ -7,10 +7,11 @@ | |||
| "import" | |||
| ], | |||
| "rules": { | |||
| "arrow-body-style": 0 | |||
| "arrow-body-style": 0, | |||
| "react/jsx-closing-bracket-location": 0 | |||
There was a problem hiding this comment.
なぜかVSCodeのESLint autosaveと相性が悪く、かつ体裁のルールなので、オフで問題ないと思い一旦オフにしてます 😓
There was a problem hiding this comment.
↓これはESLint pluginのautosaveをONにした状態で「保存」を試している例なのですが、なぜかインデント戻ってしまうのです。autosaveをdisableにするか、ここのルールだけignoreするかで考えて、後者を選びました。
There was a problem hiding this comment.
なるほど。一旦disableしてしかるべきところに報告できるといいすな。
There was a problem hiding this comment.
はい。たぶんPlugin側かな... issues ないか見てみます。
|
LGTM |
|
レビューありがとうございます. マージします。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React storybookを導入します。
メリット
将来的には、
build/配下にstaticなHTMLファイルとして生成したものを、Github Pagesのデモサイトとしても利用できます。Image
yarn story:startで下記のデベロッパーツールが開きます。@bitjourney/developers
レビューお願いします。