Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): make help match default element list #13

Merged
merged 2 commits into from
Apr 26, 2016

Conversation

kaicarver
Copy link
Contributor

the cli usage doc did not reflect the current default list of elements localized:

it was:

$ s18n help extract
   ...
    -e, --elements [elems]    html elements to localize [default: 'title,p,h1,h2,h3,h4,h5,h6' | none: '.']

but the default in lib/extract.js is:

options.elements = arrayify(options.elements) || ['title', 'h1', 'h2', 'h3', 'h4', 'h5', 'h6', 'p', 'small', 'a', 'button'];

the cli usage doc did not reflect the current default list of elements localized
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f985dbe on kaicarver:master into a1fecfc on bitjson:master.

@bitjson
Copy link
Owner

bitjson commented Apr 26, 2016

Looks great, thanks!

@bitjson bitjson merged commit f11a09b into bitjson:master Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants