Fix failing tests on Windows #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks @cspotcode! |
|
@cspotcode I didn't realize that Node.js' path.relative() always return a *nix style path. This works, so I merged this version already (thanks for the PR!) – have you seen path.normalize()? Should we use that rather than the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
Tests fail on Windows.
Tests pass on Windows. (not completely; see below)
hashAllTheThingsused to return paths with native separators, which did not match the hard-coded posix-style paths elsewhere in the tests.Tests still do not completely pass because the latest version of execa is using an outdated version of cross-spawn with a bug. They've merged a PR to upgrade but haven't published it to NPM yet. sindresorhus/execa#131