Adjust sha1_random_uuid usage in jabber/conference.c #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The jabber/conference.c module failed to compile due to the implicit use
of the sha1_random_uuid function following the deprecation of the sha1
lib. This patch reintroduces the sha1.h include to resolve compilation
errors encountered with GCC 14:
error: implicit declaration of function ‘sha1_random_uuid’
Additionally, the patch corrects the type mismatch error when calling
sha1_random_uuid, aligning with the expected ‘GChecksum **’ type,
otherwise compilation fails with following error:
error: passing argument 1 of ‘sha1_random_uuid’ from incompatible pointer type
note: expected ‘GChecksum **’ {aka ‘struct _GChecksum **’} but argument is of type ‘GChecksum *’ {aka ‘struct _GChecksum *’}
Fixes: a4ac9c4 ("Deprecate sha1_* functions (bitlbee#172)")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
jabber/conference.cmodule failed to compile due to the implicit use of thesha1_random_uuidfunction following the deprecation of the sha1 lib. This patch reintroduces thesha1.hinclude to resolve compilation errors encountered with GCC 14:Additionally, the patch corrects the type mismatch error when calling
sha1_random_uuid, aligning with the expectedGChecksum **type, otherwise compilation fails with following error:Fixes: a4ac9c4 ("Deprecate sha1_* functions (#172)")