Lowering xmpp presence priority on away. #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if (jd->away_state->code != NULL) { | ||
| int new_prio = (atoi(prio) - 5); | ||
| if (new_prio < 0) |
There was a problem hiding this comment.
style nitpick: {...} are required now even for one line blocks
When user set's away lower xmpp presence priority by 5 as most clients do, new priority won't go below zero though.
|
Merged to develop as 24f113b. Thanks! |
seveas
pushed a commit
to seveas/bitlbee
that referenced
this pull request
Feb 28, 2016
Many thanks to kinnison for reporting this bug. This bug should not have a practical impact as a properly sized buffer will not overflow. It is nonetheless important to be accurate in these types of checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user set's away lower xmpp presence priority by 5 as most clients do, new
priority won't go below zero though.
Basically the same patch as at https://bugs.bitlbee.org/bitlbee/ticket/1164 but with updated codestyle.
Not sure if this needs a separate setting to choose the away priority.