Refactor the client to supports the context versions methods #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to `client_impl.go` file
Joker-hh
commented
Apr 26, 2024
Comment on lines
+43
to
+47
| if ctx != nil { | ||
| req, err = http.NewRequestWithContext(ctx, method, targetUrl, bodyReader) | ||
| } else { | ||
| req, err = http.NewRequest(method, targetUrl, bodyReader) | ||
| } |
There was a problem hiding this comment.
this is the core refactor of how we supported the context methods, guys should keep in mind it when reviewing the other refactors
There was a problem hiding this comment.
The methods in this file were not taking any large refactoring, just moved from the client.go to here, and support to passes the context.Context arg of the methods
|
@git-hulk Just reminding you to not forget this PR. It's ok to take a review any time you free. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
For go programming,
contextis an approach to enable the callers to interpret the process positively.However, The LMSTFY client just doesn't support it, So the PR tries to provide many new methods and support to pass the context into the client implementation process.