This repository has been archived by the owner on Apr 9, 2021. It is now read-only.
link_encoders_by_count #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as per bitly api documentation there should be optional parameters 'login' and 'full_name' for getting information about particular user, so modified user_info method method link_encoders_by_count is missing. hence I added it
| """return or update info about a user""" | ||
| data = self._call_oauth2("v3/user/info", kwargs) |
There was a problem hiding this comment.
The previous call should correctly pass login and full_name along when called with .user_info(login=....). Were you encountering a problem with that?
This change is problematic because it switches to _call_oauth2_metrics instead of continuing to use _call_oauth2. Can you revert this change? If you'd like to list login and full_name in the signature, the right way to do that is kwargs['login'] = login etc.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Bitly API documentation there should be optional parameters 'login' and 'full_name' for getting information about particular user, so modified user_info method
Method link_encoders_by_count is missing. hence I added it