nsqlookupd: improved performance of registration db #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -113,9 +113,20 @@ func (r *RegistrationDB) RemoveRegistration(k Registration) { | |||
| delete(r.registrationMap, k) | |||
| } | |||
|
|
|||
| func (r *RegistrationDB) needFilter(category string, key string, subkey string) bool { | |||
There was a problem hiding this comment.
you can drop category from this function parameter list as it's not used.
|
Nice improvements. Squash in that one small fix and we'll merge this in. |
without '*' expression of topic & channel, we can fetch results from map directly.
xiaost
force-pushed
the
tmp-imprv-nsqlookupd-performance
branch
from
0f3eaef
to
1d1f725
Compare
|
@jehiah 👍 fixed |
jehiah
added a commit
that referenced
this pull request
May 7, 2015
nsqlookupd: improved performance of registration db.
mreiferson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without '*' expression of topic & channel, we can fetch results from map directly.
it is another issue we found in #577, nsqlookupd eat up my CPUs 😢