Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with end of p fields #1

Open
lwinkler opened this issue Apr 28, 2013 · 1 comment
Open

Issue with end of p fields #1

lwinkler opened this issue Apr 28, 2013 · 1 comment

Comments

@lwinkler
Copy link

Hi. Just noticed that your script to parse the markdown and add your own divs leaves the

in the html code.

Your code should probably be someting like:

   html.gsub!(/^<p>\[(.*?)\/\]<\/p>/m, '<div class="\1"></div>')

instead of

    html.gsub!(/^<p>\[(.*?)\/\]/m, '<div class="\1"></div>')

Thanks for this utility !

@bitlyfied
Copy link
Owner

Good spot!
If you feel like raising a pull request I'll merge it.
It's easy with tiny changes. You could just use the Github Edit button from here:
https://github.com/bitlyfied/markdown-cv/blob/master/Rakefile

By the way, if you plan to use it in real life, make sure you make some tests printing the output pdf.
I recently had a job interview. Some of the interviewers printed my CVs, and the layout was all wrong!
I suspect it was an issue with a missing font on Windows machines, but I haven't confirmed yet.

Let me know how it goes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants