Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make datasources for Grafana dashboard configurable #188

Merged
merged 6 commits into from
Mar 7, 2024

Conversation

Ornias1993
Copy link
Contributor

@Ornias1993 Ornias1993 commented Mar 1, 2024

Does what is states on the tin.
Adds a little selectionbox up-top to select the datasource instead of hardcoding one.

@Ornias1993 Ornias1993 marked this pull request as ready for review March 1, 2024 09:31
@Ornias1993 Ornias1993 changed the title Make Prometheus Datasource for Grafana dashboard configurable Make datasources for Grafana dashboard configurable Mar 1, 2024
@mgdigital
Copy link
Collaborator

Thanks, looks good and I'll test it when I get a chance. Just a couple of small things:

  • could you revert the casing change to bitmagnet?
  • should the next version be 2 rather than 3?
  • what is that "id": 79 referring to?

@Ornias1993

This comment was marked as resolved.

@DyonR
Copy link

DyonR commented Mar 1, 2024

  • Shouldn't names be cased like names?

It just a style choice to have bitmagnet all lowercase. For example, the brand adidas is also stylized with all lowercase.
You would also write BitTorrent and not Bittorrent, and you also wouldn't write QBittorrent, but qBittorrent. It are all style choices of the authors.
Edit:
One more example (to give a Dutch example); bol, formerly known as bol.com, is also a brand which uses only lowercase letters. (except in the history section and if sentences start with bol)
You can see bol only written in lowercase: https://pers.bol.com/nl/het-verhaal/

@Ornias1993

This comment was marked as off-topic.

@mgdigital mgdigital merged commit 5dd1678 into bitmagnet-io:main Mar 7, 2024
9 checks passed
truecharts-admin added a commit to truecharts/charts that referenced this pull request Mar 11, 2024
… v0.7.12@07c9c43 by renovate (#19063)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/bitmagnet-io/bitmagnet](https://togithub.com/bitmagnet-io/bitmagnet)
| patch | `0.7.7` -> `0.7.12` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>bitmagnet-io/bitmagnet
(ghcr.io/bitmagnet-io/bitmagnet)</summary>

###
[`v0.7.12`](https://togithub.com/bitmagnet-io/bitmagnet/releases/tag/v0.7.12)

[Compare
Source](https://togithub.com/bitmagnet-io/bitmagnet/compare/v0.7.10...v0.7.12)

#### What's Changed

- Fix Torznab content type criteria by
[@&#8203;mgdigital](https://togithub.com/mgdigital) in
[bitmagnet-io/bitmagnet#209
- fix duplicate word in index.md by
[@&#8203;sweetbbak](https://togithub.com/sweetbbak) in
[bitmagnet-io/bitmagnet#208
- Add external resources page by
[@&#8203;mgdigital](https://togithub.com/mgdigital) in
[bitmagnet-io/bitmagnet#202
- Upgrade GitHub Actions and fix Docker build by
[@&#8203;mgdigital](https://togithub.com/mgdigital) in
[bitmagnet-io/bitmagnet#201
- Fix actions: Use name and key for matrix by
[@&#8203;mgdigital](https://togithub.com/mgdigital) in
[bitmagnet-io/bitmagnet#210

#### New Contributors

- [@&#8203;sweetbbak](https://togithub.com/sweetbbak) made their first
contribution in
[bitmagnet-io/bitmagnet#208

**Full Changelog**:
bitmagnet-io/bitmagnet@v0.7.10...v0.7.12

###
[`v0.7.10`](https://togithub.com/bitmagnet-io/bitmagnet/releases/tag/v0.7.10)

[Compare
Source](https://togithub.com/bitmagnet-io/bitmagnet/compare/v0.7.9...v0.7.10)

#### What's Changed

- Show version info on webui by
[@&#8203;poruta99](https://togithub.com/poruta99) in
[bitmagnet-io/bitmagnet#205
- Fix metrics endpoint by
[@&#8203;mgdigital](https://togithub.com/mgdigital) in
[bitmagnet-io/bitmagnet#207

#### New Contributors

- [@&#8203;poruta99](https://togithub.com/poruta99) made their first
contribution in
[bitmagnet-io/bitmagnet#205

**Full Changelog**:
bitmagnet-io/bitmagnet@v0.7.9...v0.7.10

###
[`v0.7.9`](https://togithub.com/bitmagnet-io/bitmagnet/releases/tag/v0.7.9)

[Compare
Source](https://togithub.com/bitmagnet-io/bitmagnet/compare/v0.7.8...v0.7.9)

#### What's Changed

- Fix Docker build by
[@&#8203;mgdigital](https://togithub.com/mgdigital) in
[bitmagnet-io/bitmagnet#200

**Full Changelog**:
bitmagnet-io/bitmagnet@v0.7.8...v0.7.9

###
[`v0.7.8`](https://togithub.com/bitmagnet-io/bitmagnet/releases/tag/v0.7.8)

[Compare
Source](https://togithub.com/bitmagnet-io/bitmagnet/compare/v0.7.7...v0.7.8)

This release includes several minor bug fixes.

#### What's Changed

- Fix comma-separated Torznab categories by
[@&#8203;mgdigital](https://togithub.com/mgdigital) in
[bitmagnet-io/bitmagnet#194
- Rebuild webui by [@&#8203;mgdigital](https://togithub.com/mgdigital)
in
[bitmagnet-io/bitmagnet#195
- Fix Postgres call on CLI by
[@&#8203;mgdigital](https://togithub.com/mgdigital) in
[bitmagnet-io/bitmagnet#196
- Upgrade actions by [@&#8203;mgdigital](https://togithub.com/mgdigital)
in
[bitmagnet-io/bitmagnet#198

#### New Contributors

- [@&#8203;RealFascinated](https://togithub.com/RealFascinated) made
their first contribution in
[bitmagnet-io/bitmagnet#193
- [@&#8203;Ornias1993](https://togithub.com/Ornias1993) made their first
contribution in
[bitmagnet-io/bitmagnet#188

**Full Changelog**:
bitmagnet-io/bitmagnet@v0.7.7...v0.7.8

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone
Europe/Amsterdam, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjIzNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants