Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement multiplatform builds (#18) #20

Merged
merged 5 commits into from
Oct 6, 2023
Merged

Implement multiplatform builds (#18) #20

merged 5 commits into from
Oct 6, 2023

Conversation

mgdigital
Copy link
Collaborator

  • Initial multiplatform build

  • Change image name for pr

  • Fix prettier errors

  • Handle semver

Thanzex and others added 5 commits October 6, 2023 14:15
@Thanzex
Implement multiplatform builds (#18)
73a6a5c 
* Initial multiplatform build

* Change image name for pr

* Fix prettier errors

* Handle semver

---------

Co-authored-by: Francesco Bruno <f.bruno.dev@gmail.com>
@mgdigital
Avoid dirty version number
b0a43d9
@mgdigital
Remove v prefix
7a4fe18
@mgdigital
Add tags option
820e78c
@mgdigital
Fix tags?
77a7874
@Thanzex
Copy link
Contributor

Thanzex commented Oct 6, 2023

I can see it's still adding the latest to the beta tag, I did test this condition and the latest wasn't applied as you can see here
https://github.com/Thanzex/bitmagnet/actions/runs/6432243372/job/17466684475#step:3:40
Also, i can't quite figure out why it's failing now when it was fine a few minutes ago

@mgdigital
Copy link
Collaborator Author

i can't quite figure out why it's failing now when it was fine a few minutes ago

I'm trying a few things. I think we were editing the metadata-action in the wrong place, there's another one further down - just trying a new build. The docs don't quite apply to doing a push-by-digest so.....

@mgdigital
Copy link
Collaborator Author

Okay I've now got the lack-of-latest-tag working on the most recent beta. Pushing a non-beta now, if that works we should be good to merge.

@mgdigital mgdigital merged commit 869bd0d into main Oct 6, 2023
17 checks passed
@mgdigital mgdigital deleted the docker-multiplatform branch October 6, 2023 15:06
@mgdigital
Copy link
Collaborator Author

Woop it works! Thanks for your help @Thanzex

mgdigital added a commit that referenced this pull request Oct 9, 2023
@mgdigital @Thanzex
@myyc @NiklasBr
Merge from main (#36)
f579290 
* Implement multiplatform builds (#18) (#20)

* Implement multiplatform builds (#18)

* Initial multiplatform build

* Change image name for pr

* Fix prettier errors

* Handle semver

---------

Co-authored-by: Francesco Bruno <f.bruno.dev@gmail.com>

* Avoid dirty version number

* Remove v prefix

* Add tags option

* Fix tags?

---------

Co-authored-by: Francesco Bruno <b.frenc@hotmail.it>
Co-authored-by: Francesco Bruno <f.bruno.dev@gmail.com>

* parsing uint from env variable (#26)

* Use torrent_contents.info_hash instead of torrent_contents.id in Torznab result (#30)

* Add nil check (#31)

* Fix error message re: meta info from any pers (#34)

Co-authored-by: mgdigital <mgdigital@users.noreply.github.com>

* `docker-compose` is deprecated, use `docker compose` (#32)

Co-authored-by: mgdigital <mgdigital@users.noreply.github.com>

* Update issue templates (#33)

* Update issue templates

---------

Co-authored-by: Francesco Bruno <b.frenc@hotmail.it>
Co-authored-by: Francesco Bruno <f.bruno.dev@gmail.com>
Co-authored-by: myyc <myyc@users.noreply.github.com>
Co-authored-by: Niklas <niklas.brunberg@cag.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mgdigital @Thanzex