Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extranonce antminer #7

Closed

Conversation

hyperwang
Copy link

Modular implemention of extranonoce.subscribe which is disabled by default and can by enabled by URL optional parameter #xnsub.
Fix pool authorization bug.

@kenshirothefist
Copy link

@xjl2000, please revert (remove) the previous commit for extranonoce in your repo and then merge this commit instead. This patch is now 100% tested and working with AntMiner S1 and AntMiner S3, see also here for results on testing: https://bitcointalk.org/index.php?topic=850620.msg9621985#msg9621985
Actually the code for extranonoce.subscribe has NOT changed, hyperwang only fixed a bug with switching to secondary pool if primary pool disconnects with authorization failure and fixed some logging.

And it would be great if you could provide binaries with this patch for AntMiners S4 and AntMiner C1 as well ... please compile them and let me know where can we download them from.

Thank you and keep up the good work!

@kenshirothefist
Copy link

@xjl2000, just checking if you made any progress on this topic? many users are asking for this to be in antminers firmware... thanks!

@RyleaStark
Copy link

I'd like to see some updates on this topic for the S4 as well.

@kenshirothefist
Copy link

@xjl2000, did you ever applied this commit?

@xjl2000
Copy link

xjl2000 commented Mar 24, 2015

i did it times ago,all of Bitmain miners support extranonoce.subscribe.i am sorry that i did not make a claim about it,but my fellow has taken over my job of cgminer.

@xjl2000
Copy link

xjl2000 commented Mar 24, 2015

just forgot to inform him about this

@kenshirothefist
Copy link

OK, but please just make sure that the patch in this pull request is actually applied (not the older, original patch, because the older original patch has the pool authorization bug).

@xjl2000
Copy link

xjl2000 commented Mar 24, 2015

the pull request which merged is the new one from hyperwang.testing on S4/S5/C1,worked well.

@kenshirothefist
Copy link

the pull request which merged is the new one from hyperwang.testing on S4/S5/C1,worked well.

OK, great. Is the new cgminer already included in S4 and C1 firmware? (I know that it is in S5 firmware)

@xjl2000
Copy link

xjl2000 commented Mar 24, 2015

yes,they all included new cgminer supporting extranonce

@xjl2000 xjl2000 closed this Mar 26, 2015
@kenshirothefist
Copy link

We have received feedback from users, suggesting that the patch you're using is still the older one and not the one, discussed in this pull request. Once again, please include this newer patch since it fixes a small bug when switching to backup pools when using extranonce.subscribe. The correct patch is this:

nicehash@4e9c7ce

Please use this patch in your future firmware releases. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants