Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BITMAKER 2105: add notification support for user actions #142

Merged
merged 18 commits into from Apr 27, 2023
Merged

BITMAKER 2105: add notification support for user actions #142

merged 18 commits into from Apr 27, 2023

Conversation

Jgaldos
Copy link
Contributor

@Jgaldos Jgaldos commented Jan 30, 2023 •
edited

Description

add a notification service, each time a user make a change on the project, that should be notified to all project users via email

Issue

Checklist before requesting a review

  • I have performed a self-review of my code.
  • My code follows the style guidelines of this project.
  • I have made corresponding changes to the documentation.
  • New and existing tests pass locally with my changes.
  • If this change is a core feature, I have added thorough tests.
  • If this change affects or depends on the behavior of other estela repositories, I have created pull requests with the relevant changes in the affected repositories. Please, refer to our official documentation.
  • I understand that my pull request may be closed if it becomes obvious or I did not perform all of the steps above.

@Jgaldos Jgaldos force-pushed the BITMAKER-2105-1 branch 2 times, most recently from 42e417c to 4fbe08b Compare February 20, 2023 02:25
@raymond1242
Copy link
Contributor

@Jgaldos Everything it's OK.
Just one issue, There are some notifications from a user "deploy_manager". This user is created only to deploy spiders, that user should be in the notification. So every action where the user is "deploy_manager" need to be ignored

raymond1242
raymond1242 approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@raymond1242 raymond1242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GoodJob!

@raymond1242 raymond1242 self-requested a review March 20, 2023 20:54
@raymond1242 raymond1242 self-assigned this Apr 3, 2023
@raymond1242 raymond1242 requested review from mgonnav and raymond1242 and removed request for raymond1242 April 3, 2023 14:37
@raymond1242 raymond1242 removed their request for review April 19, 2023 00:31
@raymond1242
Copy link
Contributor

@emegona This PR is ready for review

@mgonnav mgonnav changed the base branch from main to estela-notifications April 27, 2023 01:54
@mgonnav mgonnav merged commit a6f5b1d into estela-notifications Apr 27, 2023
1 check passed
@mgonnav mgonnav deleted the BITMAKER-2105-1 branch April 27, 2023 02:03
raymond1242 pushed a commit that referenced this pull request Jun 4, 2023
@Jgaldos @mgonnav
BITMAKER 2105: add notification support for user actions (#142)
5a60734 
* Add Notification model
* Add notification message and notification handler
* Add notification view and generate new api-doc for notifications
* Show brief preview on header notification icon
* Add inbox notifications page
* Save Notification on project update

---------

Co-authored-by: Raymond Negron <raymond1242@Raymonds-MacBook-Air.local>
Co-authored-by: emegona <mateo@emegona.com>
mgonnav added a commit that referenced this pull request Jun 12, 2023
@raymond1242 @Jgaldos @mgonnav
BITMAKER-2971: Add actions notifications to estela (#188)
2da9074 
Related: #142 

* Add Notification model
* Add notification message and notification handler
* Add notification views
* Show a brief preview on the header notification icon
* Add inbox notifications page
* Add seen field for every user notification
* Fix case when a superuser tried to add itself to a project
* When clicking a notification, mark it as seen

---------

Co-authored-by: José Galdos Chávez <jgaldoschavez@gmail.com>
Co-authored-by: Raymond Negron <raymond1242@Raymonds-MacBook-Air.local>
Co-authored-by: mgonnav <mateo@emegona.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raymond1242 raymond1242 raymond1242 approved these changes

@mgonnav mgonnav Awaiting requested review from mgonnav

Assignees

@raymond1242 raymond1242

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jgaldos @raymond1242 @mgonnav