Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache stats in Redis while jobs are running #206

Merged
merged 7 commits into from
Jul 11, 2023
Merged

Cache stats in Redis while jobs are running #206

merged 7 commits into from
Jul 11, 2023

Conversation

mgonnav
Copy link
Member

@mgonnav mgonnav commented Jul 10, 2023 •
edited

Description

  • Retrieve stats from Redis for jobs in RUNNING state.

Issue

Checklist before requesting a review

  • I have performed a self-review of my code.
  • My code follows the style guidelines of this project.
  • I have made corresponding changes to the documentation.
  • New and existing tests pass locally with my changes.
  • If this change is a core feature, I have added thorough tests.
  • If this change affects or depends on the behavior of other estela repositories, I have created pull requests with the relevant changes in the affected repositories. Please, refer to our official documentation.
  • I understand that my pull request may be closed if it becomes obvious or I did not perform all of the steps above.

mgonnav and others added 4 commits February 7, 2023 19:22
@mgonnav
BITMAKER-1980: Save real-time stats in Redis (#144)
4c34db9 
* Retrieve job stats from Redis if the job is running
* Catch Exception rather than PyMongo exceptions
* Add unless-stopped restart policy to docker services
* Save stats from Redis when job is manually stopped
@mgonnav
Update with main branch
222e665
@mgonnav
Fix conflicts
06320cc
@mgonnav
Fix imports
d5a7383
@mgonnav mgonnav requested a review from Adriana618 July 10, 2023 18:59
@mgonnav mgonnav self-assigned this Jul 10, 2023
Adriana618
Adriana618 approved these changes Jul 11, 2023
View reviewed changes
estela-api/config/settings/base.py Outdated Show resolved Hide resolved
@mgonnav mgonnav merged commit 5957952 into main Jul 11, 2023
@mgonnav mgonnav deleted the stats-cache branch July 11, 2023 14:17
webtaken pushed a commit that referenced this pull request Jul 17, 2023
@mgonnav @webtaken
Cache stats in Redis while jobs are running (#206)
7e02b39 
* BITMAKER-1980: Save real-time stats in Redis (#144)

* Retrieve job stats from Redis if the job is running
* Catch Exception rather than PyMongo exceptions
* Add unless-stopped restart policy to docker services
* Save stats from Redis when job is manually stopped
webtaken pushed a commit that referenced this pull request Jul 17, 2023
@mgonnav @webtaken
Cache stats in Redis while jobs are running (#206)
1262db4 
* BITMAKER-1980: Save real-time stats in Redis (#144)

* Retrieve job stats from Redis if the job is running
* Catch Exception rather than PyMongo exceptions
* Add unless-stopped restart policy to docker services
* Save stats from Redis when job is manually stopped
webtaken pushed a commit that referenced this pull request Jul 17, 2023
@mgonnav @webtaken
Cache stats in Redis while jobs are running (#206)
ea6f415 
* BITMAKER-1980: Save real-time stats in Redis (#144)

* Retrieve job stats from Redis if the job is running
* Catch Exception rather than PyMongo exceptions
* Add unless-stopped restart policy to docker services
* Save stats from Redis when job is manually stopped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adriana618 Adriana618 Adriana618 approved these changes

Assignees

@mgonnav mgonnav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mgonnav @Adriana618