Feature/modules #24
Merged
Feature/modules #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
opening it up i get these build errors? anything specific to your environment that you changed? |
|
Could this be a problem because of the 2.8.+ dependency?
I didn't change anything specifically but gradle has been a huge PITA :(.
…On Wed, 12 Sep 2018 at 15:46, Cory Zachman ***@***.***> wrote:
opening it up i get these build errors? anything specific to your
environment that you changed?
[image: image]
<https://user-images.githubusercontent.com/447500/45429135-f7042000-b6a2-11e8-885d-1d33e8c69dcd.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFeUDHyGSaqMGid2BgSSPWqMFQZ9G1Jks5uaRAlgaJpZM4WlWMt>
.
|
hawk23
reviewed
Sep 13, 2018
| @@ -75,7 +75,7 @@ public EventData(BitmovinAnalyticsConfig bitmovinAnalyticsConfig, String impress | |||
| this.path = bitmovinAnalyticsConfig.getPath(); | |||
| this.experimentName = bitmovinAnalyticsConfig.getExperimentName(); | |||
| this.playerTech = Util.getPlayerTech(); | |||
| this.setUserAgent(Util.getUserAgent(bitmovinAnalyticsConfig.getContext())); | |||
| this.setUserAgent("unknown"); //Util.getUserAgent(bitmovinAnalyticsConfig.getContext())); | |||
There was a problem hiding this comment.
Do you plan to find a solution here or will it stay "unknown" for now?
| @@ -0,0 +1,5 @@ | |||
| package com.bitmovin.analytics.adapters; | |||
|
|
|||
| public class PlayerAdapterFactory { | |||
hawk23
approved these changes
Sep 13, 2018
|
@hawk23 the two test apps in the repo do exactly that .. |
peterpf
pushed a commit
that referenced
this pull request
Apr 20, 2021
…h-filters-to-be-set feature/updte-contenful-link-with-filters-to-be-set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the modules around to have a bitmovin-analytics-exoplayer and bitmovin-analyltics-bitmovin-player package