Fix misplaced SettingsPanelPageOpenButton in Firefox and IE / Edge #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…refox and IE / Edge
protyposis
suggested changes
Oct 2, 2018
CHANGELOG.md
Outdated
| @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/). | |||
| - Unresponsive UI when a user canceled connection establishment to a Cast receiver | |||
| - Avoid unnecessary animation when `BufferingOverlay` is hidden | |||
| - Avoid unnecessary DOM modification when the text of a `Label` does not change | |||
| - Offset positioning of `SettingsPanelPageOpenButton` in some Browsers | |||
There was a problem hiding this comment.
Positioning of `SettingsPanelPageOpenButton` in some browsers
|
I'm not able to reproduce the Edge behaviour. The IE issue is reproducible but weird. |
|
Strange, cannot reproduce either today :) |
protyposis
approved these changes
Oct 8, 2018
# Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As noticed in a test for #180 this is a fix for the misplaced SettingsPanelPageOpenButton in Firefox and IE / Edge.