Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mp4MuxingList should return Mp4Muxing #4

Merged
merged 1 commit into from Nov 3, 2017

Conversation

namor
Copy link
Contributor

@namor namor commented Nov 3, 2017

encoder.muxing.mp4.build erroneously returns a TsMuxing instance.
This should return a Mp4Muxing instance

@codecov
Copy link

codecov bot commented Nov 3, 2017

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   98.79%   98.79%           
=======================================
  Files          95       95           
  Lines        1825     1825           
=======================================
  Hits         1803     1803           
  Misses         22       22
Impacted Files Coverage Δ
...ovin/encoding/encodings/muxings/mp4_muxing_list.rb 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eb22f1...75a5bf1. Read the comment docs.

@Tigraine
Copy link
Member

Tigraine commented Nov 3, 2017

Awesome thanks!

@Tigraine Tigraine merged commit 1939f56 into bitmovin:master Nov 3, 2017
@namor namor deleted the fix-mp4muxing-initialization branch November 3, 2017 15:13
@namor
Copy link
Contributor Author

namor commented Nov 3, 2017

@Tigraine could I request that you rebase master into the #3 branch? Using that branch for my app

@Tigraine
Copy link
Member

Tigraine commented Nov 3, 2017

@namor Done. I merged develop into #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants