Skip to content

Commit

Permalink
fix: Bring back private keys logging (#1481)
Browse files Browse the repository at this point in the history
**Description of the change**

- Fixes missing log entries in the doc

https://github.com/bitnami-labs/sealed-secrets/blob/main/docs/bring-your-own-certificates.md#see-the-new-certificates-private-keys-in-the-controller-logs

**Benefits**

<!-- What benefits will be realized by the code change? -->

**Possible drawbacks**

<!-- Describe any known limitations with your change -->

**Applicable issues**

<!-- Enter any applicable Issues here (You can reference an issue using
#) -->
- fixes
40c279f#r139767674

**Additional information**

<!-- If there's anything else that's important and relevant to your pull
request, mention that information here.-->

Signed-off-by: Ivan Sabelnikov <ivan@mapped.com>
  • Loading branch information
vavsab committed Mar 14, 2024
1 parent 0e8919a commit 88f3505
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docs/bring-your-own-certificates.md
Expand Up @@ -44,8 +44,8 @@ kubectl -n "$NAMESPACE" logs -l name=sealed-secrets-controller
controller version: v0.12.1+dirty
2020/06/09 14:30:45 Starting sealed-secrets controller version: v0.12.1+dirty
2020/06/09 14:30:45 Searching for existing private keys
2020/06/09 14:30:45 ----- sealed-secrets-key5rxd9
2020/06/09 14:30:45 ----- mycustomkeys
2020/06/09 14:30:45 registered private key secretname=sealed-secrets-key5rxd9
2020/06/09 14:30:45 registered private key secretname=mycustomkeys
2020/06/09 14:30:45 HTTP server serving on :8080
```

Expand Down
1 change: 1 addition & 0 deletions pkg/controller/main.go
Expand Up @@ -90,6 +90,7 @@ func initKeyRegistry(ctx context.Context, client kubernetes.Interface, r io.Read
if err := keyRegistry.registerNewKey(secret.Name, key, certs[0], certs[0].NotBefore); err != nil {
return nil, err
}
slog.Info("registered private key", "secretname", secret.Name)
}
return keyRegistry, nil
}
Expand Down

0 comments on commit 88f3505

Please sign in to comment.