Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manifest not compatible with Kubernetes 1.16 #269

Closed
olivierlemasle opened this issue Sep 19, 2019 · 4 comments · Fixed by #272
Closed

Manifest not compatible with Kubernetes 1.16 #269

olivierlemasle opened this issue Sep 19, 2019 · 4 comments · Fixed by #272
Assignees
@mkmik
Milestone
v0.9.1

Comments

@olivierlemasle
Copy link

olivierlemasle commented Sep 19, 2019 •
edited

The manifest used to install Sealed Secrets (https://github.com/bitnami-labs/sealed-secrets/releases/download/v0.9.0/controller.yaml) contains a Deployment under API group apps/v1beta2, which is deprecated in Kubernetes 1.16, released this week (https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/).

Therefore, the manifest does not work with K8s 1.16:

error: unable to recognize "https://github.com/bitnami-labs/sealed-secrets/releases/download/v0.9.0/controller.yaml":
no matches for kind "Deployment" in version "apps/v1beta2"
@olivierlemasle
Copy link
Author

Cf bitnami/kube-libsonnet#22 and bitnami/kube-libsonnet#23 for the fix in kube-libsonnet.

@mkmik mkmik self-assigned this Sep 19, 2019
@mkmik
Copy link
Collaborator

mkmik commented Sep 19, 2019

@olivierlemasle thanks; do you happen to know the answer to question in bitnami/kube-libsonnet#23 (comment) ?

@jjo
Copy link

jjo commented Sep 19, 2019

@olivierlemasle thanks; do you happen to know the answer to question in bitnami-labs/kube-libsonnet#23 (comment) ?

FYI I'll be tackling bitnami/kube-libsonnet#22 tomorrow, already allocated time for that.

mkmik pushed a commit that referenced this issue Sep 20, 2019
Move k8s compat window forward to 1.13-1.16
7673ba8 
Keep support for 1.13 because who uses kops is still locked to that version (or so I heard).

Manually fix 1.16 compat issue (will inherit kube-libsonnet upstream fix once bitnami/kube-libsonnet#23 lands), also just to show off a nice pattern with jsonnet where you can override your libraries too.

Tested by adding 1.16.0 minikube based integration tests (which did indeed fail before overriding to use v1 Deployments).

Closes #269
@mkmik mkmik mentioned this issue Sep 20, 2019
Merged
bors bot added a commit that referenced this issue Sep 20, 2019
@bors
Merge #272
5ef04df 
272: Move k8s compat window forward to 1.13-1.16 r=mkmik a=mkmik

Keep support for 1.13 because who uses kops is still locked to that version (or so I heard).

Manually fix 1.16 compat issue (will inherit kube-libsonnet upstream fix once bitnami/kube-libsonnet#23 lands), also just to show off a nice pattern with jsonnet where you can override your libraries too.

Tested by adding 1.16.0 minikube based integration tests (which did indeed fail before overriding to use v1 Deployments).

Closes #269

Co-authored-by: Marko Mikulicic <mkm@bitnami.com>
@bors bors bot closed this as completed in 6edcd49 Sep 20, 2019
@bors bors bot closed this as completed in #272 Sep 20, 2019
@mkmik mkmik mentioned this issue Sep 30, 2019
Closed
@mkmik mkmik added this to the v0.9.1 milestone Oct 1, 2019
@mkmik mkmik mentioned this issue Oct 1, 2019
Closed
@mkmik
Copy link
Collaborator

mkmik commented Oct 1, 2019

Fix released in v0.9.1

@k9ert k9ert mentioned this issue Sep 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkmik mkmik

Labels
None yet
Projects
None yet
Milestone
v0.9.1
Development

Successfully merging a pull request may close this issue.

Move k8s compat window forward to 1.13-1.16 bitnami-labs/sealed-secrets
3 participants
@mkmik @jjo @olivierlemasle