Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error reporting in case of missing kubeconfig when inferring namespace #313

Closed
mkmik opened this issue Nov 13, 2019 · 2 comments · Fixed by #314
Closed

Improve error reporting in case of missing kubeconfig when inferring namespace #313

mkmik opened this issue Nov 13, 2019 · 2 comments · Fixed by #314
Assignees
@mkmik
Labels
bug pr-merged
Milestone
v0.9.5

Comments

@mkmik
Copy link
Collaborator

mkmik commented Nov 13, 2019 •
edited

Sealed-secrets need to know the namespace of the secret it's sealing.
It can get the namespace in 3 ways (in order of precedence)

  1. from the -n|--namespace flag.
  2. from the input secret's metadata.
  3. from the kubeconfig file.

when the kubeconfig file is missing, we currently report a low-level error message from the k8s client library that doesn't help the user know what to do (and gets mistaken for #101)
@mkmik mkmik added the bug label Nov 13, 2019
@mkmik mkmik self-assigned this Nov 13, 2019
@mkmik mkmik mentioned this issue Nov 13, 2019
Closed
@rwhaling
Copy link

thanks for taking a look @mkmik !

@mkmik mkmik mentioned this issue Nov 13, 2019
Merged
@helpr helpr bot added the pr-available label Nov 13, 2019
bors bot added a commit that referenced this issue Nov 13, 2019
@bors
Merge #314
5670331 
314: Improve error reporting in case of missing kubeconfig when inferring namespace r=mkmik a=mkmik

Closes #313

Co-authored-by: Marko Mikulicic <mkm@bitnami.com>
@bors bors bot closed this as completed in f0319b2 Nov 13, 2019
@bors bors bot closed this as completed in #314 Nov 13, 2019
@helpr helpr bot added pr-merged and removed pr-available labels Nov 13, 2019
@mkmik mkmik added this to the v0.9.5 milestone Nov 13, 2019
@mkmik
Copy link
Collaborator Author

mkmik commented Nov 13, 2019

releases in v0.9.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkmik mkmik

Labels
bug pr-merged
Projects
None yet
Milestone
v0.9.5
2 participants
@mkmik @rwhaling