Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "bring your own cert" docs to add -days option for cert expiry #1127

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

jflowgh
Copy link
Contributor

@jflowgh jflowgh commented Mar 4, 2023

Description of the change
Update docs for "bring your own certs" as per #1126

Benefits
Docs work for generating your own certs and sealing them.

Possible drawbacks
Need to pick a sane default expiry time for docs

Applicable issues
N/A

Additional information
N/A

@agarcia-oss
Copy link
Member

Thanks for the contribution, @jflowgh ! The changes LGTM; We just need you to include the Sign-off comment in the commit as per the project's Contributing guidelines.

@josvazg
Copy link
Collaborator

josvazg commented Mar 6, 2023

A quick way to sign off one commit:

git commit --amend -s --no-edit
git push -f

@josvazg
Copy link
Collaborator

josvazg commented Mar 6, 2023

Change LGTM too, will approve once the DCO sign-off get sorted out.

Signed-off-by: jflowgh <justin.flowers@gamehive.com>
@jflowgh
Copy link
Contributor Author

jflowgh commented Mar 6, 2023

OK the signed off message is there now. Will remember for next time.

Copy link
Member

@agarcia-oss agarcia-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Collaborator

@alemorcuq alemorcuq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alemorcuq alemorcuq merged commit 1af7246 into bitnami-labs:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants