Add namespaced roles support to Helm chart #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karel Vanden Houte <karel.vandenhoute@gmail.com>
kvandenhoute
requested review from
alvneiayu,
agarcia-oss and
alemorcuq
as code owners
alvneiayu
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
this is an incredible improvement and contribution @kvandenhoute. Thanks a lot for your contribution and help.
kvandenhoute
added a commit
to kvandenhoute/sealed-secrets
that referenced
this pull request
Jun 20, 2023
Signed-off-by: Karel Vanden Houte <karel.vandenhoute@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Karel Vanden Houte karel.vandenhoute@gmail.com
Description of the change
This PR solves #1142
Add support for using Roles instead of ClusterRoles, based on additionalNamespaces
Benefits
Cluster wide roles are problematic, as not all environments allow end users to rely on them.
For instance, multi-tenant environments do not allow for Cluster Roles or impose important restrictions to include custom permissions as one off special requests.
This change allows to not use ClusterRoles, but Roles for each of the additionalNamespaces instead
Possible drawbacks
None, default values still have the same behavior as before.
Applicable issues
#1142
Additional information