Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multidoc support for yaml and json #1304

Merged
merged 7 commits into from
Sep 13, 2023

Conversation

theurichde
Copy link
Contributor

@theurichde theurichde commented Aug 23, 2023

Description of the change

Add Support for Multidoc YAML and JSON, as stated in #114

Benefits

Users can have and manage multiple secrets in one file and encrypt those secrets in one run

Possible drawbacks

  • This change does not apply to --merge-into

    • To use this with mutlidoc, we would need to specify a target secret. On the other hand, users can easily put their to-be-merged secret in a separate file
  • Kind: List resources are not considered / supported

Applicable issues

Additional information

I want to get your opinion on this approach and see if I am on the right track here.

@theurichde
Copy link
Contributor Author

Hi there 👋🏻

@alvneiayu @agarcia-oss @alemorcuq

I would like to have your feedback on this draft before raising the actual PR. Any thoughts on this approach?
Sealing & validating single and multi-doc secrets (either JSON or YAML) is implemented.

@alvneiayu
Copy link
Collaborator

thanks for your contribution @theurichde. Let me take some time to test it and review it. Again, thanks a lot.

@alemorcuq
Copy link
Collaborator

Thanks for the PR, @theurichde. Could you please check the failed linter job? The feature looks good!

@theurichde
Copy link
Contributor Author

Hey there @alvneiayu @alemorcuq 👋🏻

Linting is fixed, should be green now.

I am wondering if we should put that feature somewhere (as a side note?) in the README? Maybe in the FAQ?

For Example:

Can I encrypt multiple secrets at once in one JSON / YAML file?
-> You bet you can! Drop as many secrets as you like in one file. Make sure to separate them via ---in YAML and as extra, single objects in JSON.

@theurichde theurichde marked this pull request as ready for review September 7, 2023 18:45
@alemorcuq
Copy link
Collaborator

Hey there @alvneiayu @alemorcuq 👋🏻

Linting is fixed, should be green now.

I am wondering if we should put that feature somewhere (as a side note?) in the README? Maybe in the FAQ?

Yep, I think that would be great!

@theurichde
Copy link
Contributor Author

@alemorcuq I added a small block for multi doc support in the FAQ

alemorcuq
alemorcuq previously approved these changes Sep 12, 2023
Copy link
Collaborator

@alemorcuq alemorcuq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great PR, @theurichde, thank you very much. It is ready to be merged but, due to some recent changes, a rebase is needed. Could you do that?

Fixes bitnami-labs#114

Signed-off-by: Tim Heurich <theurichde@users.noreply.github.com>
Fixes bitnami-labs#114

Signed-off-by: Tim Heurich <theurichde@users.noreply.github.com>
Fixes bitnami-labs#114

Signed-off-by: Tim Heurich <theurichde@users.noreply.github.com>
Signed-off-by: Tim Heurich <theurichde@users.noreply.github.com>
Signed-off-by: Tim Heurich <theurichde@users.noreply.github.com>
Signed-off-by: Tim Heurich <theurichde@users.noreply.github.com>
Signed-off-by: Tim Heurich <theurichde@users.noreply.github.com>
@theurichde
Copy link
Contributor Author

@alemorcuq Thanks for reviewing! It's rebased and ready to rock 🤘🏻

@alemorcuq alemorcuq merged commit 163fc1c into bitnami-labs:main Sep 13, 2023
16 checks passed
@theurichde theurichde deleted the feat/multidoc-support branch February 16, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When sealing multiple secrets in singe yaml file only first is sealed
3 participants