Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: write help message to stdout #1377

Merged

Conversation

theurichde
Copy link
Contributor

Fixes #1359

Description of the change

Writes output of --help / -h to Stdout instead of Stderr

Benefits

Follows GNU standards for CLIs where --help --version are supposed to be printed to Stdout

Possible drawbacks

Applicable issues

Additional information

Fixes bitnami-labs#1359

Signed-off-by: Tim Heurich <theurichde@users.noreply.github.com>
Copy link
Member

@agarcia-oss agarcia-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! it seems to be working as expected

 $ ./kubeseal --help | grep version
  --version                          Print version information and exit

@agarcia-oss agarcia-oss merged commit 7f8db28 into bitnami-labs:main Nov 15, 2023
16 checks passed
@theurichde theurichde deleted the feat(#1359)/write-help-to-stdout branch November 17, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubeseal --help writes to stderr instead of stdout
2 participants