Support fetching certificate URL via proxy environment variables #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itchyny
requested review from
alvneiayu,
agarcia-oss and
alemorcuq
as code owners
itchyny
force-pushed
the
feat-fetch-cert-via-proxy-env
branch
from
71f0682
to
227f8a0
Compare
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Signed-off-by: itchyny <itchyny@cybozu.co.jp>
itchyny
force-pushed
the
feat-fetch-cert-via-proxy-env
branch
from
227f8a0
to
2fb24de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This change allows users to specify company private URL for certificate URL which requires their proxy to fetch.
Benefits
In our company, since the certificate URL requires our proxy, we always use something like
kubeseal --cert <(curl -sSf "https://example.com/our-cert-file.cert")(we sethttps_proxyenvironment variable), or sometimeswget "https://example.com/our-cert-file.cert" && kubeseal --cert "our-cert-file.cert". It would be very useful if we can directly specify the private URL to--cert.Possible drawbacks
I don't think there're any drawbacks.
Applicable issues
Additional information