add dedicated label to metrics service and servicemonitor #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaveFun83
requested review from
alvneiayu,
agarcia-oss and
alemorcuq
as code owners
Signed-off-by: HaveFun83 <38665716+HaveFun83@users.noreply.github.com>
HaveFun83
force-pushed
the
servicemonitor-fix
branch
from
13590e6
to
8dc6042
Compare
alemorcuq
approved these changes
Jan 18, 2024
|
Thanks for taking this up so fast! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Add a dedicated label to the metrics service and servicemonitor within the helmchart template.
Benefits
Only match the metrics service with the servicemonitor
Possible drawbacks
Applicable issues
Additional information