[helm] add rbac.proxier config #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-sawatzky
requested review from
alvneiayu,
agarcia-oss and
alemorcuq
as code owners
Signed-off-by: Alice Sawatzky <alice.sawatzky@farmersedge.ca>
Signed-off-by: Alice Sawatzky <alice.sawatzky@farmersedge.ca>
Signed-off-by: Alice Sawatzky <alice.sawatzky@farmersedge.ca>
alice-sawatzky
force-pushed
the
configurable-proxier-subject
branch
from
d4c6280
to
bbb2c38
Compare
|
Thanks for your PR, @alice-sawatzky. We will review it later this week. |
alemorcuq
requested changes
Feb 1, 2024
There was a problem hiding this comment.
Thanks for the PR, @alice-sawatzky. Please, check my comments below.
Signed-off-by: Alice Sawatzky <alice.sawatzky@farmersedge.ca>
Signed-off-by: Alice Sawatzky <alice.sawatzky@farmersedge.ca>
alemorcuq
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Add options to the Helm chart to configure the
proxierRole, and its RoleBinding.Benefits
This allows the user to override the default RoleBinding that grants
system:authenticatedtheproxierrole.system:authenticatedis not a very safe option in a lot of clusters, so it's important to expose this option.Possible drawbacks
This was written to preserve existing behavior by default, so as to not break compatibility. This isn't ideal as the existing behavior is insecure on GKE (and possibly other contexts as well), but since it doesn't directly expose anything damaging (but rather is a defense-in-depth measure), it's probably OK to just highlight the importance of changing this in the documentation.
Applicable issues
Additional information