Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mod=vendor to build #205

Merged
merged 1 commit into from
Jul 26, 2019
Merged

Add mod=vendor to build #205

merged 1 commit into from
Jul 26, 2019

Conversation

mkmik
Copy link
Collaborator

@mkmik mkmik commented Jul 26, 2019

No description provided.

@mkmik mkmik requested a review from atomatt July 26, 2019 08:24
atomatt
atomatt approved these changes Jul 26, 2019
View reviewed changes
Copy link

@atomatt atomatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They need to make this the default already :)

@mkmik
Copy link
Collaborator Author

mkmik commented Jul 26, 2019

They need to make this the default already :)

indeed: golang/go#27227

@mkmik mkmik force-pushed the go-vendor branch 3 times, most recently from da0acb8 to ec0c0ea Compare July 26, 2019 09:17
@mkmik
Copy link
Collaborator Author

mkmik commented Jul 26, 2019

@atomatt PTAL

@mkmik
Copy link
Collaborator Author

mkmik commented Jul 26, 2019

bors r+

bors bot added a commit that referenced this pull request Jul 26, 2019
@bors
Merge #205
ea625f8 
205: Add mod=vendor to build r=mkmik a=mkmik



Co-authored-by: Marko Mikulicic <mkm@bitnami.com>
@bors
Copy link
Contributor

bors bot commented Jul 26, 2019

Build succeeded

@bors bors bot merged commit a4eefa7 into master Jul 26, 2019
@bors bors bot deleted the go-vendor branch July 26, 2019 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomatt atomatt atomatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkmik @atomatt