Unseal templates even when encryptedData is empty #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@twz123 nice pr but looks like no one from bitnami will review |
|
hi @twz123 Let me investigate a little bit to understand the change in the code and I will review it. I am going to be one of the maintainer in charge of the review. Sorry for the delay Thanks a lot Álvaro |
|
hi @twz123 Could you do a rebase, please? The PR was created before to fix the pipeline and the checks jobs are blocked. Just to verify that we are not breaking anything. Thanks Álvaro |
Introduce some utility functions to make tests more concise.
Previouly, SealedSecrets with empty encryptedData fields but with non-empty template.data fields were unsealed into empty Secrets. Change this by removing the check for non-empty encryptedData fields.
twz123
force-pushed
the
templates-with-empty-encrypted-data
branch
from
62d2fa1
to
89dbfc8
Compare
|
@alvneiayu rebased as requested |
alvneiayu
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
LGTM, do you have any concern about this @mkmik @juan131 @agarcia-oss?
juan131
approved these changes
Jan 27, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, SealedSecrets with empty encryptedData fields but with non-empty template.data fields were unsealed into empty Secrets. Change this by removing the check for non-empty encryptedData fields.