fix: address some golangci-lint issues #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hezhizhen
requested review from
juan131,
alvneiayu,
mkmik and
agarcia-oss
as code owners
juan131
requested changes
Feb 24, 2022
Comment on lines
-352
to
-381
| func (c *Controller) updateSecret(ctx context.Context, newSecret *corev1.Secret) (*corev1.Secret, error) { | ||
| existingSecret, err := c.sclient.Secrets(newSecret.GetObjectMeta().GetNamespace()).Get(ctx, newSecret.GetObjectMeta().GetName(), metav1.GetOptions{}) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to read existing secret: %s", err) | ||
| } | ||
| existingSecret = existingSecret.DeepCopy() | ||
| existingSecret.Data = newSecret.Data | ||
|
|
||
| c.updateOwnerReferences(existingSecret, newSecret) | ||
|
|
||
| return existingSecret, nil | ||
| } | ||
|
|
||
| func (c *Controller) updateOwnerReferences(existing, new *corev1.Secret) { | ||
| ownerRefs := existing.GetOwnerReferences() | ||
|
|
||
| for _, newRef := range new.GetOwnerReferences() { | ||
| found := false | ||
| for _, ref := range ownerRefs { | ||
| if newRef.UID == ref.UID { | ||
| found = true | ||
| break | ||
| } | ||
| } | ||
| if !found { | ||
| ownerRefs = append(ownerRefs, newRef) | ||
| } | ||
| } | ||
| existing.SetOwnerReferences(ownerRefs) | ||
| } |
There was a problem hiding this comment.
@mkmik do you know why is this unused? Tech debt?
There was a problem hiding this comment.
it's a leftover from some refactoring, possibly when the k8s client API got updated.
it's dead code, let's remove it
juan131
added
backlog
…pkg/apis/sealed-secrets/v1alpha1
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Benefits
Possible drawbacks
Applicable issues
Additional information