Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linter errors running golangci-lint #771

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Fix linter errors running golangci-lint #771

merged 1 commit into from
Mar 17, 2022

Conversation

alvneiayu
Copy link
Collaborator

Description of the change

Fix all the errors listed executing golangci-lint

  • Remove unused functions disabledTestRoundTrip and ssecretFuzzerFuncs
  • AddToScheme return is not checked
  • use buf.String() instead of string(buf.Bytes())
  • Error return values is not checked

Benefits

Prepare the code to have no linter errors

@alvneiayu alvneiayu added this to Inbox in Sealed Secrets via automation Mar 10, 2022
@alvneiayu alvneiayu self-assigned this Mar 10, 2022
@alvneiayu alvneiayu added backlog Issues/PRs that will be included in the project roadmap enhancement labels Mar 10, 2022
@alvneiayu alvneiayu moved this from Inbox to In progress in Sealed Secrets Mar 10, 2022
juan131
juan131 approved these changes Mar 10, 2022
View reviewed changes
Copy link
Collaborator

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvneiayu alvneiayu merged commit b023eaf into bitnami-labs:main Mar 17, 2022
Sealed Secrets automation moved this from In progress to Completed Mar 17, 2022
@alvneiayu alvneiayu mentioned this pull request Mar 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agarcia-oss agarcia-oss agarcia-oss approved these changes

@juan131 juan131 juan131 approved these changes

@mkmik mkmik Awaiting requested review from mkmik

Assignees

@alvneiayu alvneiayu

Labels
backlog Issues/PRs that will be included in the project roadmap enhancement
Projects
Sealed Secrets
  
Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alvneiayu @agarcia-oss @juan131